Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow query params in redirects #5081

Merged
merged 10 commits into from
Jan 23, 2019
Merged

Allow query params in redirects #5081

merged 10 commits into from
Jan 23, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 9, 2019

Closes #4384

@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Jan 9, 2019
@stsewd
Copy link
Member Author

stsewd commented Jan 9, 2019

Python2 failure is because of urlib.parse, we can merge this after #4543

@stsewd stsewd requested a review from a team January 9, 2019 01:42
humitos
humitos reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

I noted some things, though.

readthedocs/core/resolver.py Outdated Show resolved Hide resolved
readthedocs/core/views/serve.py Outdated Show resolved Hide resolved
readthedocs/redirects/utils.py Outdated Show resolved Hide resolved
readthedocs/core/resolver.py Outdated Show resolved Hide resolved
readthedocs/core/resolver.py Show resolved Hide resolved
readthedocs/rtd_tests/tests/test_redirects.py Show resolved Hide resolved
@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Jan 10, 2019
@stsewd stsewd removed PR: work in progress Pull request is not ready for full review Status: blocked Issue is blocked on another issue labels Jan 22, 2019
@stsewd stsewd requested a review from a team January 22, 2019 00:08
ericholscher
ericholscher approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@ericholscher ericholscher merged commit 5e28401 into readthedocs:master Jan 23, 2019
@stsewd stsewd deleted the allow-query-params-in-redirects branch January 23, 2019 16:23
@mgeier mgeier mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stsewd @ericholscher @humitos @agjohnson